Skip to content

Add verify-gen CI jobs #72586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunzhaohua2 wants to merge 1 commit into from
Closed

Add verify-gen CI jobs #72586

sunzhaohua2 wants to merge 1 commit into from

Conversation

@sunzhaohua2
Copy link
Contributor

@sunzhaohua2 sunzhaohua2 commented Dec 15, 2025

This adds the verify-gen presubmit job to CAPI providers to automatically verify generated files

@openshift-ci openshift-ci bot requested review from chrischdi and damdo December 15, 2025 04:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunzhaohua2
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 15, 2025

[REHEARSALNOTIFIER]
@sunzhaohua2: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-vsphere-master-verify-gen openshift/cluster-api-provider-vsphere presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-vsphere-release-4.20-verify-gen openshift/cluster-api-provider-vsphere presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-vsphere-release-4.21-verify-gen openshift/cluster-api-provider-vsphere presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-vsphere-release-4.22-verify-gen openshift/cluster-api-provider-vsphere presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-verify-gen openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.20-verify-gen openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.21-verify-gen openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-release-4.22-verify-gen openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-nutanix-main-verify-manifests openshift/cluster-api-provider-nutanix presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-nutanix-release-4.21-verify-manifests openshift/cluster-api-provider-nutanix presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-nutanix-release-4.22-verify-manifests openshift/cluster-api-provider-nutanix presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-azure-master-verify-gen openshift/cluster-api-provider-azure presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-azure-release-4.20-verify-gen openshift/cluster-api-provider-azure presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-verify-gen openshift/cluster-api-provider-azure presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-azure-release-4.22-verify-gen openshift/cluster-api-provider-azure presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-gcp-master-verify-gen openshift/cluster-api-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-gcp-release-4.20-verify-gen openshift/cluster-api-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-gcp-release-4.21-verify-gen openshift/cluster-api-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-gcp-release-4.22-verify-gen openshift/cluster-api-provider-gcp presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@sunzhaohua2: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2026

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2026
@damdo
Copy link
Member

damdo commented Jan 14, 2026

Hey @sunzhaohua2 is this still relevant?
Where was this coming from? thanks!

@sunzhaohua2
Copy link
Contributor Author

sunzhaohua2 commented Jan 15, 2026

Hey @sunzhaohua2 is this still relevant? Where was this coming from? thanks!

@damdo I think yes, this comes from https://issues.redhat.com/browse/OCPBUGS-66893 this can remind us to check if manifests is up to date

@sunzhaohua2
Copy link
Contributor Author

sunzhaohua2 commented Jan 15, 2026

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2026
@damdo
Copy link
Member

damdo commented Jan 15, 2026 •
edited
Loading

@sunzhaohua2 ah I see what you mean here.
Though here you are invoking the make verify-gen job in the root of the CAPI providers forks.
Whereas the bug you linked https://issues.redhat.com/browse/OCPBUGS-66893 was an issue with the manifests-gen not being ran correctly after a manual rebase/resync on the CAPI provider fork.

If I understood correctly what you want to achieve here, I think that's what I asked @RadekManak to look into doing, I think he has started creating a POC for that here #71392 and here openshift/cluster-api-provider-aws#579

@sunzhaohua2
Copy link
Contributor Author

sunzhaohua2 commented Jan 18, 2026

@sunzhaohua2 ah I see what you mean here. Though here you are invoking the make verify-gen job in the root of the CAPI providers forks. Whereas the bug you linked https://issues.redhat.com/browse/OCPBUGS-66893 was an issue with the manifests-gen not being ran correctly after a manual rebase/resync on the CAPI provider fork.

If I understood correctly what you want to achieve here, I think that's what I asked @RadekManak to look into doing, I think he has started creating a POC for that here #71392 and here openshift/cluster-api-provider-aws#579

Thanks @damdo let me close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@damdo damdo Awaiting requested review from damdo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunzhaohua2 @openshift-ci-robot @openshift-bot @damdo